Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor symonClient initiate function #1175

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Refactor symonClient initiate function #1175

merged 11 commits into from
Nov 15, 2023

Conversation

ilmiawan
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. to fix Refactor symonClient initiate to be more compact  #1174
  2. refactoring event emitter on symonClient initiate function

How did you implement / how did you fix it

  1. refactor callback function inside notification.willSend event emitter
  2. set alertId to be sent from an event emit

How to test

  1. run monika in symon mode
  2. make sure the notification is sent

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (1ce0a68) 61.11% compared to head (230e970) 61.25%.

❗ Current head 230e970 differs from pull request most recent head 94f45ef. Consider uploading reports for the commit 94f45ef to get more accurate results

Files Patch % Lines
src/utils/alert-id.ts 27.27% 7 Missing and 1 partial ⚠️
src/symon/index.ts 28.57% 5 Missing ⚠️
src/components/probe/prober/index.ts 75.00% 4 Missing ⚠️
src/components/probe/prober/http/index.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   61.11%   61.25%   +0.13%     
==========================================
  Files         106      107       +1     
  Lines        3140     3151      +11     
  Branches      536      535       -1     
==========================================
+ Hits         1919     1930      +11     
  Misses       1036     1036              
  Partials      185      185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sapiderman
sapiderman approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dennypradipta
dennypradipta approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennypradipta dennypradipta merged commit 1e5cf52 into hyperjumptech:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapiderman sapiderman sapiderman approved these changes

@dennypradipta dennypradipta dennypradipta approved these changes

@nicnocquee nicnocquee Awaiting requested review from nicnocquee

@raosan raosan Awaiting requested review from raosan

@haricnugraha haricnugraha Awaiting requested review from haricnugraha

@kevin-hyperjump kevin-hyperjump Awaiting requested review from kevin-hyperjump

@lukman7788 lukman7788 Awaiting requested review from lukman7788

@herenacreative herenacreative Awaiting requested review from herenacreative

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor symonClient initiate to be more compact
3 participants
@ilmiawan @sapiderman @dennypradipta